Is my client with bladder sensitivity correct in her intuitive impression she was in a past life as a teacher who expected her young children to maintain strict self control?

This, indeed, is an important part of the story, although not all, but is a beautiful starting point she can use to focus on, to work on her own healing, so that is a divine clue that can be helpful to her as well as validation she is on the right track in understanding herself and her personal circumstances.